Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: Rewrite to avoid conflicts and allow for doc generation #18024

Open
wants to merge 88 commits into
base: main
Choose a base branch
from
Open

types: Rewrite to avoid conflicts and allow for doc generation #18024

wants to merge 88 commits into from
+4,170 −3,538

Conversation

alii
Copy link
Member

@alii alii commented Mar 9, 2025 •
edited
Loading

What does this PR do?

This PR rearranges all of bun-types to support a format the aids removing conflicts with Node.js AND lib.dom.d.ts, as well as declaring the Bun namespace and other symbols in a way we can generate documentation from the TypeScript types directly.

Fixes #13599
Fixes #8761
Fixes #13167
Fixes #17203
Fixes #17256
Fixes #13858
Fixes #16044

todo:

  • rewrite the types
  • publish @oven/typescript-bun-lib-dom
  • figure out CI for autopatching dom..? (might not be necessary)
  • see if we can get BodyInit & HeadersInit to be declared inside of Bun types, not dom

alii added 21 commits March 5, 2025 21:10
@robobun
Copy link

robobun commented Mar 9, 2025 •
edited
Loading

Updated 11:25 AM PT - Mar 20th, 2025

❌ @alii, your commit 9fec62e has 7 failures in Build #13604:

🧪   try this PR locally:

bunx bun-pr 18024

@alii alii marked this pull request as ready for review March 17, 2025 13:49
@alii alii mentioned this pull request Mar 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alii @robobun @KilianB